add logical plan distributed optimizer to query frontend #6974
+610
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
reviewed
Aug 15, 2025
| FragmentAddr string | ||
| } | ||
|
|
||
| func NewRemoteNode() Node { |
There was a problem hiding this comment.
This might need to take expr as a parameter
| return []*Node{&r.Expr} | ||
| } | ||
| func (r *Remote) String() string { | ||
| return fmt.Sprintf("%s%s", r.Op.String(), r.Expr.String()) |
There was a problem hiding this comment.
We need to mention the node name remote. Maybe similar to what Thanos has fmt.Sprintf(remote(%s), r.Expr.String())
yeya24
reviewed
Aug 15, 2025
rubywtl
force-pushed
the
distributed-optimizer
branch
2 times, most recently
from
d12b7f8 to
11e8995
Compare
yeya24
reviewed
Aug 22, 2025
rubywtl
force-pushed
the
distributed-optimizer
branch
from
11e8995 to
e7384c5
Compare
yeya24
approved these changes
Aug 29, 2025
Signed-off-by: rubywtl <[email protected]>
rubywtl
force-pushed
the
distributed-optimizer
branch
from
e7384c5 to
8d33af3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implements a distributed optimizer in the distributed execution middleware that introduces remote nodes in the logical plan to mark fragmentation points. It focuses on binary aggregation queries and includes un-marshal functionality to maintain remote node integrity in the processing pipeline
Which issue(s) this PR fixes:
For distributed query execution feature
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]